Open
Conversation
grzegorzkoper
force-pushed
the
rocky-doca-example
branch
from
07f089b to
9b16c29
Compare
priteau
reviewed
Sep 18, 2025
| libnl3-devel libtool numactl-devel systemd-devel \ | ||
| kernel-rpm-macros glibc-devel pciutils gcc valgrind-devel \ | ||
| iptables-devel bison libdb-devel elfutils-devel \ | ||
| tcsh binutils-devel flex gcc-gfortran python3-Cython \ |
Member
There was a problem hiding this comment.
Is gcc-gfortran really required?
| dnf makecache && \ | ||
| dnf install -y doca-ofed-userspace && \ | ||
| dnf install -y --disablerepo=doca doca-kernel-* && \ | ||
| dnf clean all No newline at end of file |
| DIB_RELEASE: "jammy" | ||
| DIB_CLOUD_INIT_DATASOURCES: "ConfigDrive" | ||
|
|
||
| # Rocky Linux 9 with Doca Ofed enabled. |
| DIB_CONTAINERFILE_RUNTIME: docker | ||
| YUM: dnf | ||
| DIB_CLOUD_INIT_DATASOURCES: "OpenStack, ConfigDrive" | ||
| DIB_RELEASE: "9.6" |
Member
There was a problem hiding this comment.
I think various tests in DIB expect DIB_RELEASE to be just the major version?
mnasiadka
reviewed
Sep 18, 2025
| RUN systemd-machine-id-setup | ||
|
|
||
| # Install base build dependencies required by DOCA OFED | ||
| RUN dnf config-manager --set-enabled appstream crb && \ |
Member
There was a problem hiding this comment.
Can we move these into a DIB element? Leaving all packages in the image is a security anti-pattern - at least let's remove them as a final step?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.